Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions client/modules/IDE/components/Header/MobileNav.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,9 @@
const userIsOwner = user?.username === project.owner?.username;
const Logo = AsteriskIcon;

const showPrivacyToggle =
project?.owner && title === project.name && userIsOwner;
const showOwner = project?.owner && title === project.name && !userIsOwner;

const toggleVisibility = (e) => {

Check warning on line 254 in client/modules/IDE/components/Header/MobileNav.jsx

View workflow job for this annotation

GitHub Actions / Test and lint code base

'toggleVisibility' is assigned a value but never used

Check warning on line 254 in client/modules/IDE/components/Header/MobileNav.jsx

View workflow job for this annotation

GitHub Actions / Test and lint code base

'toggleVisibility' is assigned a value but never used
try {
const isChecked = e.target.checked;
dispatch(
Expand All @@ -274,17 +272,6 @@
</LogoContainer>
<Title>
<h1>{title === project?.name ? <ProjectName /> : title}</h1>
{showPrivacyToggle && (
<main className="toolbar__makeprivate">
<p>Private</p>
<input
className="toolbar__togglevisibility"
type="checkbox"
onChange={toggleVisibility}
defaultChecked={project.visibility === 'Private'}
/>
</main>
)}
{showOwner && <h5>by {project?.owner?.username}</h5>}
</Title>

Expand Down
1 change: 0 additions & 1 deletion client/modules/IDE/components/Header/Toolbar.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useEffect, useCallback } from 'react';

Check warning on line 1 in client/modules/IDE/components/Header/Toolbar.jsx

View workflow job for this annotation

GitHub Actions / Test and lint code base

'useEffect' is defined but never used

Check warning on line 1 in client/modules/IDE/components/Header/Toolbar.jsx

View workflow job for this annotation

GitHub Actions / Test and lint code base

'useState' is defined but never used

Check warning on line 1 in client/modules/IDE/components/Header/Toolbar.jsx

View workflow job for this annotation

GitHub Actions / Test and lint code base

'useEffect' is defined but never used

Check warning on line 1 in client/modules/IDE/components/Header/Toolbar.jsx

View workflow job for this annotation

GitHub Actions / Test and lint code base

'useState' is defined but never used
import classNames from 'classnames';
import PropTypes from 'prop-types';
import { useTranslation } from 'react-i18next';
Expand Down Expand Up @@ -122,7 +122,6 @@
</div>
)}

{/* ✅ Still show owner if not you */}
{project?.owner && !userIsOwner && (
<p className="toolbar__project-owner">
{t('Toolbar.By')}{' '}
Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/components/SketchListRowBase.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const SketchListRowBase = ({
<th scope="row">{name}</th>
<td>{formatDateCell(sketch.createdAt, mobile)}</td>
<td>{formatDateCell(sketch.updatedAt, mobile)}</td>
<td hidden={!userIsOwner}>
<td hidden={!userIsOwner || mobile}>
<VisibilityDropdown
sketch={sketch}
onVisibilityChange={handleVisibilityChange}
Expand Down
14 changes: 14 additions & 0 deletions client/styles/components/_console.scss
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@
& path {
fill: getThemifyVariable('secondary-text-color');
}
&:hover {
& g,
& polygon,
& path {
fill: getThemifyVariable('logo-color');
}
}
}
.preview-console--collapsed & {
display: none;
Expand All @@ -72,6 +79,13 @@
& path {
fill: getThemifyVariable('secondary-text-color');
}
&:hover {
& g,
& polygon,
& path {
fill: getThemifyVariable('logo-color');
}
}
}
display: none;
.preview-console--collapsed & {
Expand Down
12 changes: 9 additions & 3 deletions client/styles/components/_visibility-dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

@include themify() {
border-bottom: 1px solid getThemifyVariable("modal-border-color");
background-color: white;
background-color: getThemifyVariable("modal-background-color");
}

&:last-child {
Expand All @@ -54,14 +54,20 @@

&:hover {
@include themify() {
background-color: getThemifyVariable("table-row-stripe-color") !important;
background-color: getThemifyVariable("file-selected-color") !important;
}
}

&.selected {
@include themify() {
background-color: getThemifyVariable("search-background-color");
background-color: getThemifyVariable("table-row-stripe-color");
}

// &:hover {
// @include themify() {
// background-color: getThemifyVariable("table-row-stripe-color") !important;
// }
// }
}
}

Expand Down
2 changes: 1 addition & 1 deletion contributor_docs/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Contributor Documentatation
# Contributor Documentation
This folder contains guides for contributing to the p5.js Web Editor. You don't need to know everything to get started—explore at your own pace! To begin, we highly recommend starting with the [Contribution Guide](https://github.com/processing/p5.js-web-editor/blob/develop/.github/CONTRIBUTING.md)!

These guides aren't exhaustive, and do not cover all the possible ways you can contribute to a project. If you have an idea for how you'd like to help and don't see a guide for it here, you're welcome to add it to the "Documents to Create" list below by opening an issue!
Expand Down
2 changes: 1 addition & 1 deletion contributor_docs/s3_configuration.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# S3 Bucket Configuration
1. [Create an S3 bucket](https://docs.aws.amazon.com/AmazonS3/latest/userguide/create-bucket-overview.html), with any name
1. [Create an S3 bucket](https://docs.aws.amazon.com/AmazonS3/latest/userguide/create-bucket-overview.html), with any name.
2. Navigate to the S3 bucket permissions and add the following CORS policy. This is for development only, as it allows CORS from any origin.
```
[
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "p5.js-web-editor",
"version": "2.17.1",
"version": "2.17.2",
"description": "The web editor for p5.js.",
"scripts": {
"clean": "rimraf dist",
Expand Down
Loading