Skip to content

replaced connect with useSelector hook #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2024
Merged

replaced connect with useSelector hook #3113

merged 3 commits into from
Jun 5, 2024

Conversation

@PiyushChandra17
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 commented May 8, 2024

Fixes #3112

Changes:

Made the following changes:

  • replaced connect with useSelector hook
  • Removed mapStateToProps

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim added Type:Task Tasks tied specifically to developer operations and maintenance Enhancement Improvement to an existing feature labels Jun 3, 2024
raclim
raclim approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

@raclim raclim merged commit 80af258 into processing:develop Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

Enhancement Improvement to an existing feature Type:Task Tasks tied specifically to developer operations and maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor react-redux in AssetSize component

2 participants

@PiyushChandra17 @raclim