Saving unsaved Sketch before signing in with Oauth. #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindapaiste
approved these changes
Jan 14, 2024
Collaborator
lindapaiste
left a comment
lindapaiste
left a comment
There was a problem hiding this comment.
Awesome! I had not tried out my proposed fix to see if it actually works. You've tried it out and verified it so now it seems good to go 👍. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2334
Changes:
Props to @lindapaiste , he/she figured out how to sort this out while I just stuck two pieces together :)
#2424 (comment)
bandicam.2024-01-13.14-29-38-628.mp4
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123