fix autocapitalize in mweb safari

[PiyushChandra17]

Fixes #2623

Changes:

Added autoCapitalize attribute and set it to none

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[lindapaiste]

Awesome! I didn't know about this autocapitalize attribute. Now I am looking at the specs on MDN and I see this:

The autocapitalize attribute never causes autocapitalization to be enabled for an <input> element with a type attribute whose value is url, email, or password.

And I see that we have these two inputs set to type="text" instead of the more specific type="email". So I think we should change the type. We can keep the autocapitalize to be safe, but it seems like it's not strictly needed if we have the correct <input> type.

[PiyushChandra17]

@lindapaiste Even if we set to type="email" doesn't seem to work, if we remove autoCapitalize attribute. Can you please verify. I think same is happening on sign up username form field aswell where we have specified type="text". I think autoCapitalize is mandatory here.

[lindapaiste]

@lindapaiste Even if we set to type="email" doesn't seem to work, if we remove autoCapitalize attribute. Can you please verify. I think same is happening on sign up username form field aswell where we have specified type="text". I think autoCapitalize is mandatory here.

Sorry to drag you in circles but now I realize that you had it right the first time. I didn't see that the login input accepts email OR username, so we should stay with type="text" and autoCapitalize="none" because the input is not always an email address.

On the sign up form there is an email field which is always an email, lines 82-89. That one has type="email" so I'm not sure if we need the autoCapitalize there or not. I think not?

[PiyushChandra17]

@lindapaiste Yes, we don't need autoCapitalize here:

p5.js-web-editor/client/modules/User/components/SignupForm.jsx

Lines 81 to 88 in f725abd

	<input
	className="form__input"
	aria-label={t('SignupForm.EmailARIA')}
	type="email"
	id="email"
	autoComplete="email"
	{...field.input}
	/>

[soniyadotp]

is this issue closed?