Skip to content

Conversation

@raclim
Copy link
Collaborator

@raclim raclim commented Feb 23, 2023

Fixes #issue-number

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim raclim linked an issue Feb 23, 2023 that may be closed by this pull request
@release-com release-com bot deployed to p5.js-web-editor: catarak-2123-update-p5js-to-160 (ted1489) February 23, 2023 01:57 Active
@release-com
Copy link

release-com bot commented Feb 23, 2023

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-c98db7cca9

@raclim raclim merged commit b85f597 into develop Feb 23, 2023
@raclim raclim deleted the 2123-update-p5js-to-160 branch February 23, 2023 02:03
@lindapaiste
Copy link
Collaborator

@raclim You missed some:
https://github.com/processing/p5.js-web-editor/blob/develop/client/modules/Preview/filesReducer.js
https://github.com/processing/p5.js-web-editor/blob/develop/server/scripts/examples-gg-latest.js

IMO it's crazy that we have the same constants in so many files. It makes this sort of maintenance a nightmare. I'd like to put in a PR to export/import this from some central location.

@raclim
Copy link
Collaborator Author

raclim commented Feb 27, 2023

Thanks for pointing this out! These files were probably missed during the last few updates as well.

Agreed, I think narrowing the changes to one variable or location would be a great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update p5.js to 1.6.0

3 participants