Improved visibility of selections on the settings #2011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
lindapaiste
approved these changes
Jul 19, 2022
Collaborator
lindapaiste
left a comment
lindapaiste
left a comment
There was a problem hiding this comment.
This looks great! The current selections are barely visible.
Contributor
Author
|
@raclim ping |
raclim
approved these changes
Feb 6, 2023
Collaborator
raclim
left a comment
raclim
left a comment
There was a problem hiding this comment.
This is amazing, thanks so much for doing this! :)
Aryan1982
pushed a commit
to Aryan1982/p5.js-web-editor
that referenced
this pull request
Mar 14, 2023
Improved visibility of selections on the settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2007, #2099
Changes
It was difficult to see which of the settings in the Light Theme was currently selected. Therefore, I have bolded the selected ones.
This makes it easier for people with color weaknesses to see what is selected.
Other experiment
I have done various tests in my local environment, including making the color of unselected items paler and changing the background to white. However, I concluded that it is difficult to create a clear difference by color with this thin font, and that bold would be most effective.
Checklist
npm run lint)npm run test)developbranch.Fixes #123