Skip to content

Conversation

@code4humanity
Copy link
Contributor

Fixes #1948

I have verified that this pull request:

  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Oct 29, 2021

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@release-com
Copy link

release-com bot commented Oct 29, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-794aa730f2

@catarak
Copy link
Member

catarak commented Oct 29, 2021

@code4humanity it seems like some of the changes you made are fixing typos, and others are a little more major. Would it be possible to have another person who speaks Brazilian Portuguese to review these changes?

tagging @byfelipesanchez, who did the original translation, to weigh in.

@code4humanity
Copy link
Contributor Author

@catarak, I agree. Most of them were fixing typos, I think the ones in line 60 and 297 were the major ones. Do you want me to remove them while we discuss the issue #1951?

@catarak
Copy link
Member

catarak commented Nov 2, 2021

I think because the changes suggested in #1951 are relatively small, we can leave this as it is.

Do you need help soliciting feedback from others?

@code4humanity
Copy link
Contributor Author

@catarak, I'm sorry for the delay in my response.

I was thinking I could revert the changes that worries you and in #1951 I could finish reviewing the whole file and create a draft PR so we can discuss it as I believe there are more modifications than the ones I wrote. What do you think?

@catarak
Copy link
Member

catarak commented Nov 17, 2021

I was thinking I could revert the changes that worries you and in #1951 I could finish reviewing the whole file and create a draft PR so we can discuss it as I believe there are more modifications than the ones I wrote. What do you think?

Fine by me!

Copy link

@cesardeazevedo cesardeazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this in now, these changes will be out after the next version update :)

@raclim raclim merged commit 08205b5 into processing:develop Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in translation

4 participants