Skip to content

Conversation

@matsragnar
Copy link
Contributor

Fixes #issue-number

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com
Copy link

release-com bot commented Oct 13, 2021

Release Environments

This pull request environment is provided by Release, learn more!
To see the status of the environment click on Environment Status below.

🔧Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-ef7ce103bc

@catarak
Copy link
Member

catarak commented Oct 19, 2021

Thanks for working on this translation!

If you look at the translation guide, you'll see that you also need to edit a couple of other files to get it to show up in the p5.js Editor.

Also, are you able to have another person review your translations?

@matsragnar matsragnar marked this pull request as draft October 21, 2021 07:47
@matsragnar matsragnar marked this pull request as ready for review October 22, 2021 07:07
@matsragnar matsragnar marked this pull request as draft October 22, 2021 07:08
@matsragnar matsragnar marked this pull request as ready for review October 22, 2021 10:57
Copy link

@ozaar ozaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! /Fellow swede using p5 in education

@catarak
Copy link
Member

catarak commented Oct 29, 2021

Thank you for working on this! Looks great to me. It's so exciting to have more and more translations come in ✨

@catarak catarak merged commit 4c9097b into processing:develop Nov 3, 2021
@matsragnar matsragnar deleted the swedish_translation branch November 4, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants