Skip to content

[#1796] update message structure sent from onerror and onunhandledrejection #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021
Merged

[#1796] update message structure sent from onerror and onunhandledrejection #1834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 31 additions & 17 deletions client/utils/consoleUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,21 @@ export const hijackConsoleErrorsScript = (offs) => {
var fileInfo = getScriptOff(lineNumber);
data = msg + ' (' + fileInfo[1] + ': line ' + fileInfo[0] + ')';
}
window.parent.postMessage([{
log: [{
method: 'error',
data: [data],
id: Date.now().toString()
}],
source: fileInfo[1]
}], '*');
window.parent.postMessage(
{
source: fileInfo[1],
messages: [
{
log: [
{
method: 'error',
data: [data],
id: Date.now().toString()
}
]
}
]
}, '*');
return false;
};
// catch rejected promises
Expand All @@ -44,14 +51,21 @@ export const hijackConsoleErrorsScript = (offs) => {
var errorNum = event.reason.stack.split('about:srcdoc:')[1].split(':')[0];
var fileInfo = getScriptOff(errorNum);
var data = event.reason.message + ' (' + fileInfo[1] + ': line ' + fileInfo[0] + ')';
window.parent.postMessage([{
log: [{
method: 'error',
data: [data],
id: Date.now().toString()
}],
source: fileInfo[1]
}], '*');
window.parent.postMessage(
{
source: fileInfo[1],
messages: [
{
log: [
{
method: 'error',
data: [data],
id: Date.now().toString()
}
]
}
]
}, '*');
}
};
`;
Expand All @@ -62,7 +76,7 @@ export const startTag = '@fs-';

export const getAllScriptOffsets = (htmlFile) => {
const offs = [];
const hijackConsoleErrorsScriptLength = 52;
const hijackConsoleErrorsScriptLength = 66;
const embeddedJSStart = 'script crossorigin=""';
let foundJSScript = true;
let foundEmbeddedJS = true;
Expand Down