Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Nov 17, 2020

  • Updated the code links in Technical Part since the codes have been updated and pointed out the different code blocks.

  • Added the details on Nav.js and i18n.js.

Fixes #1675

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

… codes have benn updated and pointed out the different code block.

Added the details on Nav.js and i18n.js.
Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thank you!

@catarak catarak merged commit d37f5f6 into processing:develop Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding more info to Technical Part is useful?

2 participants