Skip to content

[#1620] adds toBinary function to File Uploader #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020
Merged

[#1620] adds toBinary function to File Uploader #1672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5703878
[#1620] adds toBinary function to File Uploader
catarak Nov 12, 2020
dbc05ff
Merge branch 'develop' into bug/non-english-names
catarak Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion client/modules/IDE/actions/uploader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ function localIntercept(file, options = {}) {
});
}

function toBinary(string) {
const codeUnits = new Uint16Array(string.length);
for (let i = 0; i < codeUnits.length; i += 1) {
codeUnits[i] = string.charCodeAt(i);
}
return String.fromCharCode(...new Uint8Array(codeUnits.buffer));
}

export function dropzoneAcceptCallback(userId, file, done) {
return () => {
// if a user would want to edit this file as text, local interceptor
Expand Down Expand Up @@ -94,7 +102,12 @@ export function dropzoneCompleteCallback(file) {
originalFilename: file.name
};
// console.log(json, JSON.stringify(json), JSON.stringify(json).replace('"', '\\"'));
inputHidden += `${window.btoa(JSON.stringify(json))}" />`;
let jsonStr = JSON.stringify(json);
// console.log(json, jsonStr, jsonStr.replace('"', '\\"'));

// convert the json string to binary data so that btoa can encode it
jsonStr = toBinary(jsonStr);
inputHidden += `${window.btoa(jsonStr)}" />`;
// document.getElementById('uploader').appendChild(inputHidden);
document.getElementById('uploader').innerHTML += inputHidden;

Expand Down