-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Feature/autoclose brackets quotes #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/autoclose brackets quotes #1623
Conversation
…ault value set to off ) in the General Settings tab of Preferences
…by default auto-closes: ()[]{}''"``
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
@catarak kindly let me know if the changes are okay |
|
Thanks for working on this! You know, the more that I've watched folks new to programming code, the more I think this setting should be on by default. I updated this PR accordingly. Also, @oruburos, would you mind translating the following phrases to Spanish? Thank you!
|
|
Hi @catarak sure, here are my suggestions, notice that I used capital letters to start the second and third options, up to you if you want to maintain consistency with the current style.
|
|
thank you @oruburos!! |
You're welcome, is cool to see that the translations module is being used. |
Fixes #941
I have verified that this pull request:
npm run lint)Fixes #941