Skip to content

Conversation

@sagar-joshi
Copy link
Contributor

@sagar-joshi sagar-joshi commented Sep 27, 2020

Fixes #941

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #941

…ault value set to off ) in the General Settings tab of Preferences
@welcome
Copy link

welcome bot commented Sep 27, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@sagar-joshi
Copy link
Contributor Author

@catarak kindly let me know if the changes are okay

@catarak
Copy link
Member

catarak commented Sep 28, 2020

Thanks for working on this! You know, the more that I've watched folks new to programming code, the more I think this setting should be on by default. I updated this PR accordingly. Also, @oruburos, would you mind translating the following phrases to Spanish? Thank you!

"Autoclose Brackets and Quotes"
"autoclose brackets and quotes on"
"autoclose brackets and quotes off"

@oruburos
Copy link
Collaborator

Hi @catarak sure, here are my suggestions, notice that I used capital letters to start the second and third options, up to you if you want to maintain consistency with the current style.

  • "Autoclose Brackets and Quotes"
    "Cerrar automáticamente llaves y comillas"

  • "autoclose brackets and quotes on"
    "Activar cierre automático de llaves y comillas"

  • "autoclose brackets and quotes off"
    "Desactivar cierre automático de llaves y comillas"

@catarak
Copy link
Member

catarak commented Sep 29, 2020

thank you @oruburos!!

@catarak catarak merged commit e0f9f1b into processing:develop Sep 29, 2020
@sagar-joshi sagar-joshi deleted the feature/autoclose-brackets-quotes branch September 30, 2020 00:53
@oruburos
Copy link
Collaborator

thank you @oruburos!!

You're welcome, is cool to see that the translations module is being used.

@sagar-joshi sagar-joshi restored the feature/autoclose-brackets-quotes branch October 30, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete bracket and quotation mark pairs

3 participants