Skip to content

Conversation

@rubenvandeven
Copy link
Contributor

Fixes #358 so that it works on more AWS regions. I hope it fits your development guidelines, I'm not too acquainted with JS. For some reason I still didn't manage to get it running on non-Amazon S3 services.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 4, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@catarak
Copy link
Member

catarak commented Sep 8, 2020

Thank you so much for working on this! I think it's okay to not get this to work for non-Amazon S3 buckets at the moment—just opening this up to different regions is super useful, as folks are running into this issue often!

Copy link
Member

@catarak catarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and changed this a bunch but it all seems to be working now!

@catarak catarak merged commit 8ee9b6f into processing:develop Sep 11, 2020
@rubenvandeven
Copy link
Contributor Author

Still quite some changes, but great you managed to get it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 authentication doesn't work in newer AWS regions

2 participants