Skip to content

Conversation

@oruburos
Copy link
Collaborator

@oruburos oruburos commented Sep 3, 2020

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named

@oruburos
Copy link
Collaborator Author

oruburos commented Sep 3, 2020

@andrewn can you have a look at this, please?

Copy link
Member

@andrewn andrewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good. The main issues:

  • proper markdown heading levels should be used for all section titles
  • some small language tweaks

@oruburos
Copy link
Collaborator Author

oruburos commented Sep 4, 2020

@andrewn can you have a look at this, please? I updated the branch and addressed the comments.

@catarak
Copy link
Member

catarak commented Sep 4, 2020

Yay! Thanks for working on this ✨ I'm so excited that this opens up future translations for the web editor!

Copy link
Member

@andrewn andrewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! This is a great resource for future translators!

@andrewn andrewn merged commit 260a92d into processing:develop Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants