Language UI Dropdown new location #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-design' into languageUI
3 tasks
Collaborator
Author
|
@andrewn Can you have a look at this, please? |
andrewn
reviewed
Aug 27, 2020
andrewn
suggested changes
Aug 27, 2020
Member
andrewn
left a comment
andrewn
left a comment
There was a problem hiding this comment.
This is looking really good. Can you remove the en-US default prop and we're good to go!
Collaborator
Author
|
@andrewn I got ride of the language entry in default prop, can you have a look, please? |
Collaborator
Author
|
@andrewn can you have a look at this? |
andrewn
approved these changes
Aug 27, 2020
ridait
pushed a commit
to ridait/p5.js-web-editor
that referenced
this pull request
Aug 28, 2020
* New language selector design * Adjust authenticated nav to consolidate Account dropdown * Adding language in NavTest Co-authored-by: Cassie Tarakajian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #1562
I have verified that this pull request:
npm run lint)This PR locates the Language Selector in a new position, and sets a language in defaultprops to pass the test.