Skip to content

Conversation

@IdoHartuv
Copy link
Contributor

Fixes #1541

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Aug 16, 2020

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@catarak
Copy link
Member

catarak commented Aug 17, 2020

Thanks for working on this! The call to scroll the console should actually be wrapped in a useDidUpdate, so I moved it there.

@catarak catarak merged commit 371e859 into processing:develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console doesn't scroll to bottom to reveal new messages

2 participants