-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement Mobile version of Files tab / sidebar #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Mobile version of Files tab / sidebar #1539
Conversation
|
This also looks so good! It's really, really exciting 😄 The only thing I'm unsure about is the floating file button, and I'd like to try having it be one of the icons next to the console icon. |
|
Nice! I moved it to the bottom bar, and improved a couple things there |
…ilo/p5.js-web-editor into feature/mobile-files-tab
…ilo/p5.js-web-editor into feature/mobile-files-tab
|
This looks great! I'm not sure what changes i would add other than getting the dropdown button to do stuff, but that could be another PR I think. |
|
I think this one is ready 😄 |
Requires #1528
This branch implements an
<Explorer />mobile component, which uses a<Sidebar />modal component (new) as a modal. It also updates the logic of theuseAsModalHOC to support components that require the ability to close themselves (like the sidebar).npm run lint)Fixes #123