Skip to content

Conversation

@ghalestrilo
Copy link
Collaborator

Requires #1528

This branch implements an <Explorer /> mobile component, which uses a <Sidebar /> modal component (new) as a modal. It also updates the logic of the useAsModal HOC to support components that require the ability to close themselves (like the sidebar).

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@catarak
Copy link
Member

catarak commented Aug 11, 2020

This also looks so good! It's really, really exciting 😄

The only thing I'm unsure about is the floating file button, and I'd like to try having it be one of the icons next to the console icon.

@ghalestrilo ghalestrilo marked this pull request as ready for review August 11, 2020 21:11
@ghalestrilo
Copy link
Collaborator Author

Nice! I moved it to the bottom bar, and improved a couple things there

@ghalestrilo ghalestrilo requested a review from catarak August 11, 2020 21:49
@ghalestrilo ghalestrilo self-assigned this Aug 12, 2020
@catarak
Copy link
Member

catarak commented Aug 12, 2020

This looks great! I'm not sure what changes i would add other than getting the dropdown button to do stuff, but that could be another PR I think.

@catarak
Copy link
Member

catarak commented Aug 17, 2020

I think this one is ready 😄

@ghalestrilo ghalestrilo merged commit fdf60aa into processing:develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants