Skip to content

Conversation

@catarak
Copy link
Member

@catarak catarak commented Jul 16, 2020

  • Sketch duplication code now checks for AWS endpoint via environment
    variable, rather than hard-coded string
  • Fixes aws.controller#getObjectKey, which was incorrectly generating
    file keys

Fixes #1500

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

- Sketch duplication code now checks for AWS endpoint via environment
  variable, rather than hard-coded string
- Fixes `aws.controller#getObjectKey`, which was incorrectly generating
  file keys
@catarak catarak merged commit b83824d into develop Jul 16, 2020
@catarak catarak deleted the bug/duplicate-sketch-media-files branch July 20, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When duplicating a sketch, media files are not copied

2 participants