Skip to content

Conversation

@andrewn
Copy link
Member

@andrewn andrewn commented Jun 8, 2020

Fixes #1445

There's more that we should do for this, but I'll do a follow-up PR:

  • Show 404 if project is not found
  • Write tests so we know if this page fails because of some change elsewhere

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

@andrewn andrewn merged commit 3502844 into processing:develop Jun 8, 2020
@andrewn andrewn deleted the bugfix/fullscreen-1445 branch June 8, 2020 08:51
@catarak
Copy link
Member

catarak commented Jun 9, 2020

yay thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full screen preview no longer functioning

2 participants