Remove support for sx from Pagination component
#6688
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llastflowers
added
skip changeset
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5797
Current
sxusage: 0✅ Don't need to separately update github-ui components to use @primer/styled-react
Changelog
Removed
Remove support for
sxfrom thePaginationcomponent, and any associated stories, docs, and testsRollout strategy
This component currently has 0
sxusage in dotcom, and therefore does not need the @primer/styled-react wrapper. this will be confirmed again before merging.Merge checklist