-
Notifications
You must be signed in to change notification settings - Fork 626
Remove styled-system usage - misc components #6676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mperrotti
wants to merge
17
commits into
main
Choose a base branch
from
mp/rm-sx/misc-components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6569f9b
rms styled-system and styled-components usage from IssueLabelToken
mperrotti 575422b
rms styled-system and styled-components usage from ProgressBar
mperrotti d6a3e9f
rms styled-system and styled-components usage from StateLabel
mperrotti c576fa1
rms styled-system and styled-components usage from deprecated ActionL…
mperrotti 7f4b498
Merge branch 'main' of github.com:primer/react into mp/rm-sx/misc-com…
mperrotti f7014f3
rms styled-system and styled-components usage from Caret
mperrotti 17d1834
rms styled-system and styled-components usage from ToggleSwitch
mperrotti 3b335ff
addresses stylelint errors
mperrotti a282c1d
updates outdated Vitest snapshots
mperrotti 09ea1fc
Merge branch 'main' of github.com:primer/react into mp/rm-sx/misc-com…
mperrotti 059b4be
fixes broken IssueLabelToken bg color in some color modes
mperrotti 00d9906
Merge branch 'main' of github.com:primer/react into mp/rm-sx/misc-com…
mperrotti 89bb919
fixes StateLabel bordered style for dark high-contrast color modes
mperrotti b9d3c4c
adds changeset
mperrotti b7b2076
Merge branch 'main' into mp/rm-sx/misc-components
mperrotti f5f7b19
Merge branch 'main' of github.com:primer/react into mp/rm-sx/misc-com…
mperrotti 8437a2c
fixes ToggleSwitch border color for 'on' state in dark high contrast …
mperrotti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,98 @@ | ||
.StateLabel { | ||
display: inline-flex; | ||
align-items: center; | ||
font-weight: var(--base-text-weight-semibold); | ||
/* stylelint-disable-next-line primer/typography */ | ||
line-height: 16px; | ||
color: var(--fgColor-onEmphasis); | ||
text-align: center; | ||
border-radius: var(--borderRadius-full); | ||
} | ||
|
||
/* Size variants */ | ||
.StateLabel:where([data-variant='small']) { | ||
padding: var(--base-size-4) var(--base-size-8); | ||
font-size: var(--text-body-size-small); | ||
} | ||
|
||
.StateLabel:where([data-variant='normal']) { | ||
padding: var(--base-size-8) var(--base-size-12); | ||
font-size: var(--text-body-size-medium); | ||
} | ||
|
||
/* Status color variants */ | ||
.StateLabel:where([data-status='issueClosed']) { | ||
background-color: var(--bgColor-done-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-done-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='issueClosedNotPlanned']) { | ||
background-color: var(--bgColor-neutral-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-neutral-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='pullClosed']) { | ||
background-color: var(--bgColor-closed-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-closed-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='pullMerged']) { | ||
background-color: var(--bgColor-done-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-done-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='pullQueued']) { | ||
background-color: var(--bgColor-attention-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-attention-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='issueOpened']) { | ||
background-color: var(--bgColor-open-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-open-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='pullOpened']) { | ||
background-color: var(--bgColor-open-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-open-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='draft']) { | ||
background-color: var(--bgColor-neutral-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-neutral-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='issueDraft']) { | ||
background-color: var(--bgColor-neutral-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-neutral-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='unavailable']) { | ||
background-color: var(--bgColor-neutral-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-neutral-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='open']) { | ||
background-color: var(--bgColor-open-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-open-emphasis, transparent); | ||
} | ||
|
||
.StateLabel:where([data-status='closed']) { | ||
background-color: var(--bgColor-done-emphasis); | ||
color: var(--fgColor-onEmphasis); | ||
box-shadow: var(--shadow-inset) var(--borderColor-done-emphasis, transparent); | ||
} | ||
|
||
.Icon { | ||
margin-right: var(--base-size-4); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,10 +22,4 @@ Playground.argTypes = { | |
disable: true, | ||
}, | ||
}, | ||
theme: { | ||
controls: false, | ||
table: { | ||
disable: true, | ||
}, | ||
}, | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥