Skip to content

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Jul 16, 2024

Closes https://github.com/github/primer/issues/3463

Stemming from @camertron's work in #3902

Example story

Changelog

New

  • Adds new props loadingLabelDelay and loadingLabel

Changed

  • Makes aria-labelledby a required prop
  • Utilizes aria-disabled instead of disabled

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: 3d24041

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-4744 July 16, 2024 21:01 Inactive
Copy link
Contributor

github-actions bot commented Jul 16, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.23 KB (+0.23% 🔺)
packages/react/dist/browser.umd.js 90.47 KB (+0.39% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4744 July 16, 2024 21:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4744 July 16, 2024 21:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4744 July 22, 2024 16:44 Inactive
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Aug 4, 2025
Copy link
Contributor

github-actions bot commented Aug 4, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 4, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-4744 August 4, 2025 15:17 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/394584

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Aug 4, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Aug 4, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 4, 2025
Copy link
Contributor

github-actions bot commented Aug 4, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Aug 4, 2025
Copy link
Contributor

github-actions bot commented Aug 4, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-4744 August 4, 2025 19:22 Inactive
@TylerJDev TylerJDev added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 3c9e322 Aug 4, 2025
43 checks passed
@TylerJDev TylerJDev deleted the toggle-switch-a11y-fixes branch August 4, 2025 19:38
@primer primer bot mentioned this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants