-
Notifications
You must be signed in to change notification settings - Fork 626
Accessibility fixes for ToggleSwitch #4744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Tyler Jones <[email protected]>
Co-authored-by: Tyler Jones <[email protected]>
…to toggle_switch_a11y_take4
🦋 Changeset detectedLatest commit: 3d24041 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/394584 |
🟢 golden-jobs completed with status |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Closes https://github.com/github/primer/issues/3463
Stemming from @camertron's work in #3902
Example story
Changelog
New
loadingLabelDelay
andloadingLabel
Changed
aria-labelledby
a required proparia-disabled
instead ofdisabled
Rollout strategy
Testing & Reviewing
Merge checklist