Intents for all arguments #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Thank you for contributing! This definitely makes sense and is very good to have.
Since typically the issue here is the extent of changes required, I cross-checked the in/out and the imported types in all subroutines, and they look correct (besides one unused instance - please confirm).
I also checked that solverdummy runs on my system.
Instead of using the entire iso_c_binding module in each routine, import only the necessary types from the module scope. Prevents warnings emitted by some compilers and analysis tools about use-ing entire modules.
kcooley-cvd
force-pushed
the
intents-for-all-arguments
branch
from
4f659c2 to
4ca6114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intentfor all argumentsimportonly what they need fromiso_c_binding.Closes #40