fix: Fixed brazilian accent parsing when table have latin1 charset #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simolus3
reviewed
Oct 28, 2025
| break; | ||
| } | ||
|
|
||
| parser._encoding = column.charset; |
There was a problem hiding this comment.
I don't think this breaks anything, but I'm worried something else might depend on the _encoding being set to something else, and this is only really supposed to change it for the column being read. Can we call parseBuffer(size).toString(column.charset ?? parser._encoding) instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was testing your library in a project and ended up encountering a very specific issue. When a table uses the "latin1" charset and contains data with an accent, in this case, Brazilian words, the accent wasn't decoded correctly. For example, "João" became "Jo?o." While searching for alternatives, I found a solution in another fork, which is in PR.
I opened this PR to fix this issue so I can continue using the library.
Thank you.