Delegate callback now returns instance of TwicketSegmentedControl #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polqf
requested changes
Feb 20, 2017
|
|
||
| public protocol TwicketSegmentedControlDelegate: class { | ||
| func didSelect(_ segmentIndex: Int) | ||
| func twicketSegmentedControl(_ segmentedControl: TwicketSegmentedControl, didSelect segmentIndex: Int) |
There was a problem hiding this comment.
What do you think about didSelect(_ segmentIndex: Int, on segmentedControl TwicketSegmentedControl) ?
Not a big fan of how UIKit delegate methods are called
There was a problem hiding this comment.
Shouldn't it be consistent with the rest of the UIKit delegate methods (even if they're not the best)?
There was a problem hiding this comment.
I don't think we should write stuff like UIKit just for consistency when we know they are not correct
There was a problem hiding this comment.
Ok, makes sense. In that case let's go with the method you suggested.
|
@dkun7944 are you going to do the changes we talked about 😄 ? |
…x: Int, on segmentedControl: TwicketSegmentedControl)
|
@polqf Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current delegate callback makes it impossible to have multiple TwicketSegmentedControls within one class. This commit fixed this by adding the TwicketSegmentedControl instance to the delegate callback parameters.