Skip to content

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Aug 6, 2025
@coastalwhite coastalwhite force-pushed the refactor/row-encode-expression branch from 123f846 to eee85e5 Compare August 6, 2025 13:48
@coastalwhite coastalwhite force-pushed the refactor/row-encode-expression branch from eee85e5 to 6acf436 Compare August 6, 2025 13:50
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 89.16256% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.44%. Comparing base (b512da3) to head (6cf1976).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/dsl/function_expr/mod.rs 0.00% 7 Missing ⚠️
...s/polars-plan/src/plans/aexpr/function_expr/mod.rs 41.66% 7 Missing ⚠️
py-polars/polars/expr/expr.py 60.00% 3 Missing and 1 partial ⚠️
.../polars-python/src/lazyframe/visitor/expr_nodes.rs 0.00% 2 Missing ⚠️
py-polars/polars/functions/lazy.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #23933    +/-   ##
========================================
  Coverage   81.44%   81.44%            
========================================
  Files        1672     1673     +1     
  Lines      225183   225330   +147     
  Branches     2903     2907     +4     
========================================
+ Hits       183394   183521   +127     
- Misses      41064    41082    +18     
- Partials      725      727     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite marked this pull request as ready for review August 7, 2025 16:37
@coastalwhite coastalwhite merged commit fa806a6 into pola-rs:main Aug 7, 2025
26 of 29 checks passed
@coastalwhite coastalwhite deleted the refactor/row-encode-expression branch August 7, 2025 16:37
@ritchie46
Copy link
Member

Maybe we can expose it as an expression on structs as well. We have all the logic. I think it can be useful to more people.

As long as we don't guarantee a stable row-encoding across versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants