Skip to content

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Aug 1, 2025
@coastalwhite coastalwhite force-pushed the refactor/non-opt-maps branch 3 times, most recently from b0eb4ea to 191927e Compare August 4, 2025 12:12
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 79.74684% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.47%. Comparing base (376e86c) to head (6586cb4).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/dsl/mod.rs 65.90% 15 Missing ⚠️
...rates/polars-plan/src/dsl/python_dsl/python_udf.rs 75.75% 8 Missing ⚠️
crates/polars-plan/src/dsl/name.rs 0.00% 5 Missing ⚠️
py-polars/polars/functions/lazy.py 85.18% 2 Missing and 2 partials ⚠️
crates/polars-plan/src/dsl/expr/expr_dyn_fn.rs 78.57% 3 Missing ⚠️
crates/polars-plan/src/dsl/expr/serde_expr.rs 25.00% 3 Missing ⚠️
crates/polars-expr/src/expressions/apply.rs 80.00% 2 Missing ⚠️
crates/polars-ops/src/chunked_array/list/get.rs 66.66% 2 Missing ⚠️
crates/polars-plan/src/plans/visitor/expr.rs 0.00% 2 Missing ⚠️
crates/polars-plan/src/plans/aexpr/equality.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23867      +/-   ##
==========================================
+ Coverage   81.40%   81.47%   +0.06%     
==========================================
  Files        1669     1668       -1     
  Lines      225114   224785     -329     
  Branches     2903     2905       +2     
==========================================
- Hits       183259   183145     -114     
+ Misses      41130    40915     -215     
  Partials      725      725              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite marked this pull request as ready for review August 4, 2025 14:01
This updates `pl.map_batches` and `pl.map_groups` to use the same
implementation as `Expr.map_batches` and splits the `Udf` trait up into
`ColumnsUdf` and `AnonymousColumnsUdf`.
@coastalwhite coastalwhite force-pushed the refactor/non-opt-maps branch from 2ad7713 to 24216fe Compare August 5, 2025 14:55
@coastalwhite coastalwhite merged commit 400a22f into pola-rs:main Aug 7, 2025
32 of 35 checks passed
@coastalwhite coastalwhite deleted the refactor/non-opt-maps branch August 7, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant