-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
refactor(python): Improve/fix internal LRUCache
implementation and move into "_utils" module
#23813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexander-beedie
merged 3 commits into
pola-rs:main
from
alexander-beedie:improve-lrucache
Aug 1, 2025
Merged
refactor(python): Improve/fix internal LRUCache
implementation and move into "_utils" module
#23813
alexander-beedie
merged 3 commits into
pola-rs:main
from
alexander-beedie:improve-lrucache
Aug 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23813 +/- ##
=======================================
Coverage 81.41% 81.41%
=======================================
Files 1653 1654 +1
Lines 224496 224566 +70
Branches 2873 2880 +7
=======================================
+ Hits 182764 182832 +68
Misses 41018 41018
- Partials 714 716 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
165233e
to
ed8b82c
Compare
LRUCache
implementation and move into "_utils" moduleLRUCache
implementation and move into "_utils" module
8a31aa6
to
8b7f208
Compare
8b7f208
to
a3e6011
Compare
The new linting errors are unrelated; seem connected to #23825 🤔 |
Co-authored-by: nameexhaustion <[email protected]>
nameexhaustion
approved these changes
Aug 1, 2025
Washiil
pushed a commit
to Washiil/polars
that referenced
this pull request
Aug 2, 2025
…move into "_utils" module (pola-rs#23813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than take the
cachetools
dependency, we have an internalLRUCache
implementation. I found a few bugs in it and fixed them, and then added all the missing methods so that we can use it as a true drop-in for thecachetools
implementation.Also added a thorough set of unit tests to validate behaviour, and moved it into the "_utils" module as it isn't cloud-specific.
(Once merged, I'll rebase #23809 on this so that PR will work and pass tests).