Skip to content

Conversation

ldhwaddell
Copy link
Contributor

Fixes issue 23483.

Fixes issue where the skip_lines parameter in read_csv_batched was silently ignored due to being incorrectly mapped to with_skip_rows in the Rust layer. Users could not skip lines using this argument as intended, diverging behavior from read_csv.

  • Correctly wires skip_lines to with_skip_lines in the PyBatchedCsv constructor.
  • Updates Python function signature and docstring for skip_lines and skip_rows to match read_csv

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (e5ce951) to head (7ecccaf).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23484   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files        1634     1634           
  Lines      221204   221204           
  Branches     2813     2813           
=======================================
  Hits       180379   180379           
  Misses      40134    40134           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ritchie46 ritchie46 merged commit c97a307 into pola-rs:main Jul 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants