fix: Method str.zfill was inconsistent with Python and pandas when string contained leading '+'
#22985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
str.zfill was inconsistent with Python and pandas when string contained leading '+'
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22985 +/- ##
==========================================
- Coverage 80.33% 80.30% -0.03%
==========================================
Files 1682 1682
Lines 223120 223140 +20
Branches 2804 2804
==========================================
- Hits 179251 179203 -48
- Misses 43201 43268 +67
- Partials 668 669 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
10 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Aug 5, 2025
Closes #19035 Closes #16480 I believe this needs pola-rs/polars#22985 to pass the one remaining failing test and the column overload described here #19035 (comment) Authors: - https://github.com/brandon-b-miller - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Matthew Roeschke (https://github.com/mroeschke) URL: #19081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22983