perf: Optimise low-level null
scans and arg_max
for bools (when chunked)
#22897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimisations
Spotted some nice speedups for the lower-level
first_not_null
andlast_non_null
validity/bitmap scans while working on #22880; breaking them out as a standalone PR so we can take advantage while deciding on a better API for that one.So, switching out the following offset calculations...
...for (more or less)...
...and adjusting the surrounding code slightly allows us to get the required result directly from the validity bitmap without mediating via
BitMask
andnth_set_bit_idx
.Speedup:
build-dist-release
) 🚀Also:
arg_max_bool
to handle "n" chunks..index_of(None)
, and an associated small parametric test to improve edge-case coverage.