-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(rust): Add and test DataFrame equality functionality #22865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Add and test DataFrame equality functionality #22865
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22865 +/- ##
==========================================
- Coverage 81.02% 80.69% -0.34%
==========================================
Files 1674 1671 -3
Lines 237087 221446 -15641
Branches 2792 2791 -1
==========================================
- Hits 192098 178693 -13405
+ Misses 44320 42088 -2232
+ Partials 669 665 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from the .schema
everything seems. I would really like to see a follow-up PR where the python assert_frame_equal
dispatches to this 😄
Made the change to |
It is not really necessary. Thank you for PRs 😄 |
Final pull request needed to resolve #21388. Tagging @coastalwhite because he is overseeing my work on this.
As with the previous pull request for adding
assert_series_equal()
, there are in-line comments where I felt unsure and some guidance might be needed and where changes are marked, meaning they deviate from the Python code (the reason is outlined in the change). Like before, once comments are added and resolved, I will add proper documentation and examples to the code via a new commit.Any suggestions for shortening and making the code more efficient are welcome. Thank you!