Skip to content

Conversation

Kevin-Patyk
Copy link
Contributor

Final pull request needed to resolve #21388. Tagging @coastalwhite because he is overseeing my work on this.

As with the previous pull request for adding assert_series_equal(), there are in-line comments where I felt unsure and some guidance might be needed and where changes are marked, meaning they deviate from the Python code (the reason is outlined in the change). Like before, once comments are added and resolved, I will add proper documentation and examples to the code via a new commit.

Any suggestions for shortening and making the code more efficient are welcome. Thank you!

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (ee0903b) to head (f7b05e0).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22865      +/-   ##
==========================================
- Coverage   81.02%   80.69%   -0.34%     
==========================================
  Files        1674     1671       -3     
  Lines      237087   221446   -15641     
  Branches     2792     2791       -1     
==========================================
- Hits       192098   178693   -13405     
+ Misses      44320    42088    -2232     
+ Partials      669      665       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@coastalwhite coastalwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the .schema everything seems. I would really like to see a follow-up PR where the python assert_frame_equal dispatches to this 😄

@Kevin-Patyk
Copy link
Contributor Author

Made the change to .schema() and added proper documentation. Once this is merged, we can close the issue related to moving this functionality 🎉! For the follow-up PR where the Python assert_frame_equal() dispatches to this, do you want me to make a formal issue that I can be assigned to or is it not necessary?

@coastalwhite
Copy link
Collaborator

For the follow-up PR where the Python assert_frame_equal() dispatches to this, do you want me to make a formal issue that I can be assigned to or is it not necessary?

It is not really necessary. Thank you for PRs 😄

@coastalwhite coastalwhite merged commit 74b501e into pola-rs:main May 23, 2025
22 checks passed
@Kevin-Patyk Kevin-Patyk deleted the feat/add_assert_dataframe_equal branch August 4, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move assert_series_equal and assert_frame_equal implementation to Rust
2 participants