Skip to content

Conversation

Liyixin95
Copy link
Contributor

Just some renaming.

@github-actions github-actions bot added build Changes that affect the build system or external dependencies rust Related to Rust Polars labels May 6, 2025
@Liyixin95
Copy link
Contributor Author

@ritchie46 rand 0.9 use new algorithms in shuffle, which cause some test failed. Is this acceptable? If so, I will adjust the test.

@ritchie46
Copy link
Member

@ritchie46 rand 0.9 use new algorithms in shuffle, which cause some test failed. Is this acceptable? If so, I will adjust the test.

Yes, this is ok.

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 51.02041% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (50e44a2) to head (496b533).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-arrow/src/bitmap/utils/iterator.rs 0.00% 10 Missing ⚠️
crates/polars-core/src/chunked_array/random.rs 11.11% 8 Missing ⚠️
crates/polars-arrow/src/bitmap/utils/mod.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22619      +/-   ##
==========================================
- Coverage   80.71%   80.70%   -0.01%     
==========================================
  Files        1645     1645              
  Lines      221894   221894              
  Branches     2783     2783              
==========================================
- Hits       179095   179090       -5     
- Misses      42137    42142       +5     
  Partials      662      662              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Liyixin95
Copy link
Contributor Author

@ritchie46 rand 0.9 use new algorithms in shuffle, which cause some test failed. Is this acceptable? If so, I will adjust the test.

Yes, this is ok.

@ritchie46 I fix all the test now.

@ritchie46
Copy link
Member

Please ping me if I haven't merge this in in 3 days. :)

@ritchie46 ritchie46 merged commit 2c9929f into pola-rs:main Jul 2, 2025
32 checks passed
@ritchie46
Copy link
Member

Thank you @Liyixin95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants