Include watchOS 4.0 in @available check #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also faced the need for these changes. Snapshots are an iOS-only dependency and I can run tests for watchOS without any issues. But somehow the SwiftUI preview for watchOS requires these changes. It would be nice if someone could review and merge it. |
dani-gavrilov
approved these changes
Apr 25, 2022
stephencelis
approved these changes
Jun 6, 2022
|
Thanks! |
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include watchOS in the availability check for
sortedKeysallowing the library to compile under watchOS.This wouldn’t normally be necessary given that watchOS snapshots are not currently supported.
However Xcode seems to try and compile test targets when generating SwiftUI previews and so those targeting Apple Watch weren’t rendering.
This was making it difficult to work with SwiftUI previews inside modules containing views intended for both phone and watch platforms.