Use the correct scale for the diff image #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsim
approved these changes
Jun 4, 2021
|
Looks good, thanks for submitting! |
stephencelis
approved these changes
Jun 4, 2021
mac-gallagher
pushed a commit
to mac-gallagher/swift-snapshot-testing
that referenced
this pull request
Aug 22, 2021
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UIGraphicsBeginImageContextWithOptionswas setting thescaleparameter to0which will default to the device'sUIDevice.main.scale. This results in an incorrect difference image when taking snapshots for different devices. Instead, use the maximum scale of one of the passed inUIImages.