Skip to content

Add test/docs around static @Dependency usage #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Add test/docs around static @Dependency usage #97

merged 1 commit into from
Jun 1, 2023

Conversation

stephencelis
Copy link
Member

That is: don't.

Because statics are lazy, they will cache the current dependency values when first accessed, leading to unexpected behavior.

@stephencelis stephencelis requested a review from mbrandonw May 31, 2023 19:51
@acosmicflamingo
Copy link
Contributor

I wonder who found this out the hard way 😂

@stephencelis stephencelis merged commit 0216cee into main Jun 1, 2023
@stephencelis stephencelis deleted the static-notice branch June 1, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephencelis @acosmicflamingo @mbrandonw