Add UUID.init(_ intValue:) helper
#69
Conversation
|
Oh clever! I memorized 8-4-4-4-12 for creating UUIDs but looks like this will be helpful :) |
| } | ||
|
|
||
| extension UUID { | ||
| public init(_ intValue: Int) { |
There was a problem hiding this comment.
Is it working as expected if we pass -1?
Otherwise, we could restrict to UInt or take the absolute value.
EDIT: it generates 0000ffffffff, so this is not crashing, but that's maybe a little counterintuitive
There was a problem hiding this comment.
Yeah, I'd expect -1 to be all FFFFFFFF-FFFF-FFFF-FFFF-FFFFFFFFFFFF. Might make more sense to force users to pass it an unsigned integer.
There was a problem hiding this comment.
Is it working as expected if we pass -1?
I think we'd consider -1 "undefined" and leave it at that.
Otherwise, we could restrict to UInt or take the absolute value.
We prefer Int to UInt as Swift tends to do (using it for Array.count, Array.index, etc.).
We're open to improvements if folks wanna PR, but seeing as this is primarily a test helper, we're not too worried about it covering edge cases.
No description provided.