-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Bump python versions in CI and add python 3.13 #5073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.circleci/config.yml
Outdated
| # use `-browsers` prefix for selenium tests, for example, `3.12-browsers` | ||
| - image: cimg/python:3.11-browsers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of sphinx that we use doesn't support 3.10 or later. Ideally the docs build would use a more recent Python version than 3.9, but we'd need to also update the sphinx dependency and test it. I think the update would bring some visual changes to the docs. This is a related issue #4085
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roger -- I'll leave as 3.9 for now
|
OK @LiamConnors @marthacryan this is passing tests and ready for review! |
marthacryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #4935
test_coreandtest_optionalplotlyjs_dev_buildandfull_build