Skip to content

Deterministic sort order for plotly express modes #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Deterministic sort order for plotly express modes #4429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7aa1b9
Deterministic sort order for plotly express modes
alev000 Nov 17, 2023
f68a164
changelog entry for #4429
alexcjohnson Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/python/plotly/plotly/express/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,7 +1929,7 @@ def infer_config(args, constructor, trace_patch, layout_patch):
modes.add("text")
if len(modes) == 0:
modes.add("lines")
trace_patch["mode"] = "+".join(modes)
trace_patch["mode"] = "+".join(sorted(modes))
elif constructor != go.Splom and (
"symbol" in args or constructor == go.Scattermapbox
):
Expand Down
20 changes: 20 additions & 0 deletions packages/python/plotly/plotly/tests/test_optional/test_px/test_px.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,26 @@ def test_labels():
assert fig.layout.annotations[4].text.startswith("TIME")


@pytest.mark.parametrize(
["extra_kwargs", "expected_mode"],
[
({}, "lines"),
({"markers": True}, "lines+markers"),
({"text": "continent"}, "lines+markers+text"),
],
)
def test_line_mode(extra_kwargs, expected_mode):
gapminder = px.data.gapminder()
fig = px.line(
gapminder,
x="year",
y="pop",
color="country",
**extra_kwargs,
)
assert fig.data[0].mode == expected_mode


def test_px_templates():
try:
import plotly.graph_objects as go
Expand Down