Skip to content

fix setting config for MathJax v2 - ensure version 2 Hub #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2022
Merged

fix setting config for MathJax v2 - ensure version 2 Hub #3706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0ab13
ensure having MathJax.Hub before set config for MathJax v2
archmoj May 3, 2022
13f7c91
refactor using ?
archmoj May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/javascript/jupyterlab-plotly/src/Figure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,11 +826,9 @@ export class FigureView extends DOMWidgetView {
this.model.on("change:_py2js_update", this.do_update, this);
this.model.on("change:_py2js_animate", this.do_animate, this);

// MathJax configuration
// MathJax v2 configuration
Copy link
Collaborator

@alexcjohnson alexcjohnson May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a v3 equivalent?

Copy link
Contributor Author

@archmoj archmoj May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at the moment it appears: http://docs.mathjax.org/en/latest/output/fonts.html

// ---------------------
if ((window as any).MathJax) {
(window as any).MathJax.Hub.Config({ SVG: { font: "STIX-Web" } });
}
(window as any)?.MathJax?.Hub?.Config?.({ SVG: { font: "STIX-Web" } });

// Get message ids
// ---------------------
Expand Down
2 changes: 1 addition & 1 deletion packages/python/plotly/plotly/io/_base_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def __init__(self, width=None, height=None, scale=None, engine="auto"):
window.PlotlyConfig = {MathJaxConfig: 'local'};"""

_mathjax_config = """\
if (window.MathJax) {MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}"""
if (window.MathJax && window.MathJax.Hub && window.MathJax.Hub.Config) {window.MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}"""


class HtmlRenderer(MimetypeRenderer):
Expand Down
2 changes: 1 addition & 1 deletion packages/python/plotly/plotly/io/_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

_mathjax_config = """\
<script type="text/javascript">\
if (window.MathJax) {MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}\
if (window.MathJax && window.MathJax.Hub && && window.MathJax.Hub.Config) {window.MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}\
</script>"""


Expand Down
2 changes: 1 addition & 1 deletion packages/python/plotly/plotly/offline/offline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def _get_jconfig(config=None):

_mathjax_config = """\
<script type="text/javascript">\
if (window.MathJax) {MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}\
if (window.MathJax && window.MathJax.Hub && window.MathJax.Hub.Config) {window.MathJax.Hub.Config({SVG: {font: "STIX-Web"}});}\
</script>"""


Expand Down