Add deepcopy and pickle support to figures and graph objects #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to implement generic validator deepcopy support
This method provides pickle and deep copy support
This was referenced Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
deepcopyandpickleoperations on figures andgraph_objs.This PR addresses:
This does not address the performance optimizations described in #1078. Support for
pickleanddeepcopyis added by implementing a__reduce__method that simply calls the figure/graph_obj constructor with thedictrepresentation of the object.To lay a foundation for potential future optimization work, this PR also adds support for performing
deepcopyon all validator classes.