Only retry on request errors with 5XX status code and use exponential backoff #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, switch to exponential backoff to give the servers more breathing
room.
Tries in seconds:
0, 1, 2, 4, 8, 16, 16, 16... for up to 3 minutes total.
This was referenced Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1114 and changes from random retry every second or so to exponential backoff.
This should be more reliable for when the back-end servers are temporarily overwhelmed.
Tries in seconds:
0, 1, 2, 4, 8, 16, 16, 16... for up to 3 minutes total.
cc @priyatharsan