fix error bar trace ordering [fixes #338] #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz
In brief
This PR:
<g class="errorlayer">from the cartesian plot framework.<g class="trace">Important considerations
ErrorBarscomponent is now required in theScatterandBarplot and style steps, instead of being called from the module-loop inCartesian.plot.ErrorBars.calccall in the main Plotly.plot routine. The error bar calc step needs to be in thepositionAndAutorangeblock to properly update the axes ranges. Perhaps, we could make asetPositionsinScatterand have it callErrorBars.calc?