Datetime picker library issues (WIP) #316
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR only adds failing test and is not ready for merging.
There are several bugs with the datetime picker library.
It's unfortunate that it uses PHP's strftime options, while we use ruby's strftime options (for obvious reasons) on the
backend.
I've added one failing spec to demonstrate one of several issues I've encountered with this datetime picker library.

Here's the screenshot:
The issue is that the frontend js library doesn't parse the ruby's formatted date.
Here are some other "interesting" issues:
format_time
doesn't work when specified in config so it has to be specified on every input fieldwhile it actually uses a different version. More info:
Format "m/d/Y h:i a" changes hour onBlur xdan/datetimepicker#596
My advice would be to switch to another solution completely. These are just not compatible.