Skip to content

Conversation

Potherca
Copy link
Member

C4-PlantUML is compatible up to v1.2023.5 (because of the ?= operator being used).

We can't use JSON notation (i.e. $versionPart[1]) as that triggers a ClassCastException in versions older than v1.2024.5.

The function %splitstr() is safe, as it was added in v1.2022.2

Fixes #396

C4-PlantUML is compatible up to v1.2023.5 (because of the `?=` operator being used).

We can't use JSON notation (i.e. `$versionPart[1]`) as that triggers a ClassCastException in versions older than v1.2024.5.

The function `%splitstr()` is safe, as it was added in v1.2022.2

Fixes #396
@Potherca Potherca requested a review from kirchsth June 30, 2025 16:26
@Potherca Potherca self-assigned this Jun 30, 2025
Copy link
Member

@kirchsth kirchsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fast fix

@The-Lum
Copy link

The-Lum commented Jun 30, 2025

FYI @plantuml, @arnaudroques

@arnaudroques
Copy link

Thanks for the fix.
However, it should be reported in https://github.com/plantuml/plantuml-stdlib/blob/master/stdlib/C4/C4.puml
This current repo is "Unofficial" :-)

Thanks!

@kirchsth kirchsth merged commit de66183 into master Jun 30, 2025
2 checks passed
@kirchsth kirchsth deleted the fix/handwritten-warning branch June 30, 2025 19:11
@kirchsth
Copy link
Member

This current repo is "Unofficial" :-)

  1. yes unofficial, but with some nice extensions ;-)
  2. next weekend I can create a patch and update the "official" too ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning regarding handwritten option
4 participants