Skip to content

feat(app): increase max validators #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

feat(app): increase max validators #549

merged 1 commit into from
Jun 17, 2025

Conversation

@0xHansLee
Copy link
Contributor

@0xHansLee 0xHansLee commented May 21, 2025 •
edited
Loading

Implement upgrade handler to increase MaxValidators to 80

issue: none

@0xHansLee 0xHansLee self-assigned this May 21, 2025
@codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
client/app/upgrades/polybius/upgrades.go 0.00% 22 Missing ⚠️
client/app/upgrades/polybius/constants.go 0.00% 7 Missing ⚠️
client/app/upgrades.go 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@0xHansLee 0xHansLee force-pushed the hans/increase-max-val branch 3 times, most recently from cbc5f0c to f23eb5c Compare June 16, 2025 07:59
@limengformal
Copy link
Contributor

@0xHansLee codecov/patch is failing

limengformal
limengformal reviewed Jun 16, 2025
View reviewed changes
client/app/upgrades/polybius/constants.go Outdated
Comment on lines 17 to 18
// StoryUpgradeHeight defines the block height at which v1.3.0 upgrade is triggered on Mainnet.
StoryUpgradeHeight = 10000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to disable mainnet upgrade in this release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled in 9d10953

client/app/upgrades/polybius/constants.go Outdated
Comment on lines 40 to 41
case upgrades.StoryChainID:
return StoryUpgradeHeight, true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable mainnet upgrade for this release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled in 9d10953

@0xHansLee 0xHansLee force-pushed the hans/increase-max-val branch from f23eb5c to 9d10953 Compare June 17, 2025 01:02
@0xHansLee
Copy link
Contributor Author

@0xHansLee codecov/patch is failing

Yeah, since I have not covered the test for this upgrade handler. Need test suite for upgrade but we don't have for now. Since it's a simple handler and we have tested, I think we can merge this PR.

@limengformal limengformal merged commit 50c26c6 into main Jun 17, 2025
13 of 14 checks passed
@limengformal limengformal deleted the hans/increase-max-val branch June 17, 2025 02:21
@github-actions
Copy link

Binary uploaded successfully 🎉

📦 Version Name: 1.3.0-unstable-50c26c6
📦 Download Source: AWS S3

kim201212 pushed a commit to dsrvlabs/story that referenced this pull request Jul 22, 2025
@0xHansLee @kim201212
feat(app): increase max validators (piplabs#549)
82fb94a 
Implement upgrade handler to increase `MaxValidators` to 80

issue: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevemilk stevemilk stevemilk approved these changes

@limengformal limengformal limengformal approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@jdubpark jdubpark Awaiting requested review from jdubpark jdubpark is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@gezerui0124 gezerui0124 Awaiting requested review from gezerui0124 gezerui0124 is a code owner

@ramtinms ramtinms Awaiting requested review from ramtinms ramtinms is a code owner

Assignees

@0xHansLee 0xHansLee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xHansLee @limengformal @stevemilk