feat(cli): add to encrypt priv key #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHansLee
force-pushed
the
hans/enc-priv-key
branch
from
78a315e to
f2ffbd6
Compare
0xHansLee
requested review from
LeoHChen,
edisonz0718,
gezerui0124,
jdubpark,
limengformal and
ramtinms
as code owners
0xHansLee
force-pushed
the
hans/enc-priv-key
branch
from
efd9a29 to
bc1e7f3
Compare
0xHansLee
commented
Feb 28, 2025
| "github.com/piplabs/story/lib/tracer" | ||
|
|
||
| // Used for ABI embedding of the staking contract. | ||
| _ "embed" |
LeoHChen
reviewed
Feb 28, 2025
There was a problem hiding this comment.
It is generated by detect-secrets to detect leakage of secrets.
This file lists the secrets detected in our codebase. There are no actual secrets in this PR, but detect-secrets detects some codes as secret, so added to those in this file.
There was a problem hiding this comment.
Yes, updates are needed for false-positive secret keys to pass PR checks.
jdubpark
reviewed
Mar 10, 2025
| // ValidatePasswordInput validates a strong password input for new accounts, | ||
| // including a min length. | ||
| func ValidatePasswordInput(input string) error { | ||
| if len(input) < minPasswordLength { |
There was a problem hiding this comment.
We could do more weak criteria, e.g. at least one number.
There was a problem hiding this comment.
Right. This validation is the same one from Prysm. We could add more.
jdubpark
approved these changes
Mar 10, 2025
0xHansLee
force-pushed
the
hans/enc-priv-key
branch
from
bc1e7f3 to
145ceff
Compare
0xHansLee
force-pushed
the
hans/enc-priv-key
branch
from
145ceff to
5bbbd28
Compare
ramtinms
reviewed
Mar 11, 2025
ramtinms
approved these changes
Mar 11, 2025
gezerui0124
approved these changes
Mar 12, 2025
Binary uploaded successfully 🎉📦 Version Name: 1.1.2-unstable-e045276 |
kim201212
pushed a commit
to dsrvlabs/story
that referenced
this pull request
Jul 22, 2025
Support validator priv key encryption. ## Updated ### `init` command Operators can encrypt the newly generated private key with `--encrypt-priv-key` flag. Without this flag, no encryption is done for private key as before. The encrypted file is stored under `story/config/enc_priv_key.json`. For all validator CLI, the private key is retrieved from the encrypted private key file by decrypting it if the `enc_priv_key.json` file exists. Otherwise, it is retrieved from `.env` file. ## Added ### `encrypt` command To support the existing operators (using not encrypted key), one command is also added to encrypt the existing private key in `.env` file: `./story key encrypt`. It will generate the encrypted private key file under `story/config/enc_priv_key.json`. ### `show` command Also, introduced a new command to decrypt and show the encrypted key: `./story key show-encrypted`. With `--show-private` flag, user can show the private key. issue: piplabs#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support validator priv key encryption.
Updated
initcommandOperators can encrypt the newly generated private key with
--encrypt-priv-keyflag. Without this flag, no encryption is done for private key as before. The encrypted file is stored understory/config/enc_priv_key.json.For all validator CLI, the private key is retrieved from the encrypted private key file by decrypting it if the
enc_priv_key.jsonfile exists. Otherwise, it is retrieved from.envfile.Added
encryptcommandTo support the existing operators (using not encrypted key), one command is also added to encrypt the existing private key in
.envfile:./story key encrypt. It will generate the encrypted private key file understory/config/enc_priv_key.json.showcommandAlso, introduced a new command to decrypt and show the encrypted key:
./story key show-encrypted. With--show-privateflag, user can show the private key.issue: #151