Skip to content

Conversation

micheleorselli
Copy link
Member

This allows to change the default build dir when running make phar , like this

make phar TMP_DIR=~/workspace/tmp

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (3acff7c) to head (9c0d501).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #467   +/-   ##
=========================================
  Coverage     94.90%   94.90%           
  Complexity      605      605           
=========================================
  Files            69       69           
  Lines          1609     1609           
=========================================
  Hits           1527     1527           
  Misses           82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@micheleorselli micheleorselli merged commit 47e02e3 into main Mar 21, 2025
34 checks passed
@micheleorselli micheleorselli deleted the make_phar_build_dir_parametric branch March 21, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants