Skip to content

Revert "Deprecate returning non-string values from a user output handler (#18932)" #20455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: PHP-8.5
Choose a base branch
from
Open

Revert "Deprecate returning non-string values from a user output handler (#18932)" #20455

wants to merge 3 commits into from
+5 −1,123

Conversation

@DanielEScherzer
Copy link
Member

@DanielEScherzer DanielEScherzer commented Nov 11, 2025

This reverts commit d8577d9.

@DanielEScherzer
Copy link
Member Author

DanielEScherzer commented Nov 11, 2025 •
edited
Loading

Not an exact revert

  • the logic about tracking the output handler is kept, since it is also used for the deprecation warnings about producing output (07f1cfd)
  • the unrelated tests that were updated to have their output handlers return strings are not reverted
  • tests from 07f1cfd when both warnings are emitted are also deleted

@DanielEScherzer DanielEScherzer requested review from Girgias, bukka and ndossche and removed request for bukka November 11, 2025 19:15
@DanielEScherzer DanielEScherzer linked an issue Nov 11, 2025 that may be closed by this pull request
Confirm if ob_gzhandler is impacted by ob_start handler changes #20384
Open
@DanielEScherzer DanielEScherzer mentioned this pull request Nov 11, 2025
Closed
ndossche
ndossche approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@ndossche ndossche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks technically fine. Would need a clarifying NEWS entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndossche ndossche ndossche approved these changes

@Girgias Girgias Awaiting requested review from Girgias

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confirm if ob_gzhandler is impacted by ob_start handler changes

2 participants

@DanielEScherzer @ndossche