Minor refactoring of sensitive parameter handling in backtrace generation #20446
+20
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Nov 11, 2025
Zend/zend_builtin_functions.c
Outdated
| } | ||
| /* }}} */ | ||
|
|
||
| static bool backtrace_is_arg_sensitive(zend_execute_data *call, uint32_t offset) |
Member
There was a problem hiding this comment.
With #20448 the following should be possible:
Suggested change
| static bool backtrace_is_arg_sensitive(zend_execute_data *call, uint32_t offset) | |
| static bool backtrace_is_arg_sensitive(const zend_execute_data *call, uint32_t offset) |
ndossche
force-pushed
the
refactor-backtrace-stuff
branch
from
d6c532c to
461bcfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.